Optimize offset_from_unsigned result bounds - #161063
Open
SomeFlyingThing wants to merge 4 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
r? libs |
Contributor
|
Seems reasonable. For lack of any niche-type APIs that represent this, it should be okay to add this assumption. @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 14, 2026
…unsigned-bound, r=clarfonthey Optimize offset_from_unsigned result bounds Hint that result cannot be larger than isize max
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 14, 2026
…unsigned-bound, r=clarfonthey Optimize offset_from_unsigned result bounds Hint that result cannot be larger than isize max
Member
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #161089 (comment) @bors try jobs=test-various |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#161092), which was unapproved. |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 14, 2026
…und, r=<try> Optimize offset_from_unsigned result bounds try-job: test-various
Contributor
|
💔 Test for f4b1164 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
Not sure if spurious, will have to take a closer look later. |
Contributor
|
@rustbot review |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hint that result cannot be larger than isize max