Skip computing extra liveness info if borrow_set is empty - #161252
Skip computing extra liveness info if borrow_set is empty#161252jackh726 wants to merge 1 commit into
Conversation
|
Failed to set assignee to
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Skip computing extra liveness info if borrow_set is empty
|
Disclosure: An LLM was used to dig into the icu4x (and other) regressions, and identified that that and other cases have no loans - and so that this is a candidate fix. |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (4b205ca): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.3%, secondary 1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 468.493s -> 459.261s (-1.97%) |
r? lqd