[beta] bump stage0, plus backports by cuviper · Pull Request #161422 · rust-lang/rust

cuviper · 2026-08-20T18:40:35Z

View all comments

Bump stage0 to stable 1.98.0
fix buggy MaybeDangling<&T> validation logic fix buggy MaybeDangling<&T> validation logic #161125
resolving cyclic glob vis-max resolving cyclic glob vis-max #161024
Check for missing rustfmt in the stdarch intrinsic test step sooner Check for missing rustfmt in the stdarch intrinsic test step sooner #161641
Uplift rustfmt macro formatting fix Uplift rustfmt macro formatting fix #161370
Stop rustfmt deleting attributes in fn params Stop rustfmt deleting attributes in fn params #161709

r? me

(cherry picked from commit 73d3b1c)

(cherry picked from commit 3e48bd4)

rustbot · 2026-08-20T18:40:39Z

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

cuviper · 2026-08-21T00:17:05Z

@bors r+ rollup=never

rust-bors · 2026-08-21T00:17:08Z

📌 Commit 043ef18 has been approved by cuviper

It is now in the queue for this repository.

[beta] bump stage0, plus backports - Bump stage0 to stable 1.98.0 - fix buggy MaybeDangling<&T> validation logic #161125 - resolving cyclic glob vis-max #161024 r? me

rust-bors · 2026-08-22T15:32:52Z

💔 Test for b18e17a failed: CI. Failed job:

auto - aarch64-gnu (web logs, enhanced plaintext logs)

cuviper · 2026-08-23T19:52:18Z

WARNING: intrinsic-test skipped because rustfmt is required but not available on this channel
[TIMING:start] format::InternalRustfmt {  }
[TIMING:end] format::InternalRustfmt {  } -- 0.000

thread 'main' (1407) panicked at src/build_helper/src/drop_bomb/mod.rs:47:13:
command constructed at `src/bootstrap/src/core/build_steps/tool.rs:1607:23` was dropped without being executed: `/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools-bin/intrinsic-test`

That WARNING has an early return per #159265 (@xonx4l, @Kobzol), but it looks like it should defuse the command too. Even better, it could go way up near the target check, so it's before any filesystem modification.

Kobzol · 2026-08-24T06:04:53Z

Indeed, the check should be at the top of the function. #161641 should fix this.

(cherry picked from commit 226b175)

…k-fix, r=cuviper Check for missing rustfmt in the stdarch intrinsic test step sooner Found [here](rust-lang#161422 (comment)). r? cuviper

Rollup merge of #161641 - Kobzol:intrinsic-test-rustfmt-check-fix, r=cuviper Check for missing rustfmt in the stdarch intrinsic test step sooner Found [here](#161422 (comment)). r? cuviper

[beta] bump stage0, plus backports - Bump stage0 to stable 1.98.0 - fix buggy MaybeDangling<&T> validation logic #161125 - resolving cyclic glob vis-max #161024 - Check for missing rustfmt in the stdarch intrinsic test step sooner #161641 r? me

rust-bors · 2026-08-25T04:30:12Z

💔 Test for b4777f2 failed: CI. Failed job:

auto - dist-x86_64-linux (web logs, enhanced plaintext logs)

cuviper · 2026-08-25T16:46:43Z

Looks like spurious git issues.

@bors retry

(cherry picked from commit d827d44)

rustbot · 2026-08-25T17:10:43Z

rustfmt is developed in its own repository. If possible, consider making this change to rust-lang/rustfmt instead.

cc @rust-lang/rustfmt

rust-bors · 2026-08-25T17:10:44Z

⚠️ A new commit c76808a7ab688412c81ae12a8e9d609d4ef38452 was pushed.

This pull request was unapproved.

(cherry picked from commit 95b56fe)

(cherry picked from commit 27f59f4)

(cherry picked from commit 3159d9f)

(cherry picked from commit 6a1074e)

cuviper · 2026-08-25T17:33:31Z

@bors r+

rust-bors · 2026-08-25T17:33:33Z

📌 Commit 71dc937 has been approved by cuviper

It is now in the queue for this repository.

rust-bors · 2026-08-25T19:36:13Z

⌛ Testing commit 71dc937 with merge f57cf2d...

Workflow: https://github.com/rust-lang/rust/actions/runs/32890503693

[beta] bump stage0, plus backports - Bump stage0 to stable 1.98.0 - fix buggy MaybeDangling<&T> validation logic #161125 - resolving cyclic glob vis-max #161024 - Check for missing rustfmt in the stdarch intrinsic test step sooner #161641 - Uplift rustfmt macro formatting fix #161370 - Stop rustfmt deleting attributes in fn params #161709 r? me

cuviper and others added 3 commits August 20, 2026 11:09

Bump to stable 1.98.0

7155422

fix buggy MaybeDangling<&T> validation logic

6e08e31

(cherry picked from commit 73d3b1c)

resolving cyclic glob vis-max

043ef18

(cherry picked from commit 3e48bd4)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 20, 2026

rustbot assigned cuviper Aug 20, 2026

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 20, 2026

This comment has been minimized.

Sign in to view

cuviper mentioned this pull request Aug 20, 2026

Update books #161321

Merged

This comment was marked as outdated.

Sign in to view

cuviper force-pushed the beta-next branch from 104fa97 to 043ef18 Compare August 20, 2026 22:59

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2026

Kobzol mentioned this pull request Aug 24, 2026

Check for missing rustfmt in the stdarch intrinsic test step sooner #161641

Merged

Check for missing rustfmt in the stdarch intrinsic test step sooner

908f2ad

(cherry picked from commit 226b175)

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2026

Uplift rustfmt macro formatting fix

c76808a

(cherry picked from commit d827d44)

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 25, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 25, 2026

rustbot added the T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. label Aug 25, 2026

CPunisher added 4 commits August 25, 2026 10:14

Fix

b75ae66

(cherry picked from commit 95b56fe)

Add variadic test

e4de01c

(cherry picked from commit 27f59f4)

Add trait fn tests

9ba433f

(cherry picked from commit 3159d9f)

Add test for issue 6607

71dc937

(cherry picked from commit 6a1074e)

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2026

Uh oh!

Uh oh!

Conversation

cuviper commented Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

cuviper commented Aug 21, 2026

Uh oh!

rust-bors Bot commented Aug 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 22, 2026

Uh oh!

cuviper commented Aug 23, 2026

Uh oh!

Kobzol commented Aug 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 25, 2026

Uh oh!

cuviper commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

rust-bors Bot commented Aug 25, 2026

Uh oh!

cuviper commented Aug 25, 2026

Uh oh!

rust-bors Bot commented Aug 25, 2026

Uh oh!

rust-bors Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cuviper commented Aug 20, 2026 •

edited by rustbot

Loading

rust-bors Bot commented Aug 25, 2026 •

edited

Loading