Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the traps for the 15 fixed-register AMX intrinsics in #563. Use GCC builtins for tile configuration and volatile inline asm for the rest. Loads and stores carry memory clobbers so GCC cannot discard input writes or reuse stale output values.
Add assembly tests for both dialects, operand order and memory effects. Compiler-allocated tiles and newer AMX extensions are unchanged.
The assembly suite passes. All 15 upstream runtime cases passed under Intel SDE at -O0 and -O3; libcore, mini/std, Clippy and the no-default-features check also passed.
Fixes #563.