Conversation
This comment has been minimized.
This comment has been minimized.
Detect cycles instead of treating every nested always-inline call as recursive. Cache results and keep the traversal on the heap. Add an -O0 assembly regression for acyclic chains. Retain the existing always_inline runtime test for self-recursion and mutual recursion.
fbernier
force-pushed
the
fix/nested-always-inline
branch
from
September 15, 2026 02:19
b3a2235 to
935c4f4
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve
#[inline(always)]for nested, non-recursive calls by detecting cycles instead of treating any always-inline callee as recursion. The traversal is iterative and cached.Add an
-O0assembly regression. Existing tests cover self-recursion and mutual recursion.