Added org github tokens to check untracked private repositories - #2666
Open
cuba0001 wants to merge 1 commit into
Open
Added org github tokens to check untracked private repositories#2666cuba0001 wants to merge 1 commit into
cuba0001 wants to merge 1 commit into
Conversation
cuba0001
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
marcoieni and
ubiratansoares
as code owners
August 9, 2026 09:17
Dry-run check results |
marcoieni
reviewed
Aug 11, 2026
| "GITHUB_TOKEN_{}", | ||
| org.to_ascii_uppercase().replace('-', "_") | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
We already parse and select GITHUB_TOKEN_{ORG} credentials in
team/src/sync/github/api/tokens.rs
Line 194 in 0a7e85b
Could we reuse that mechanism here?
Contributor
Author
There was a problem hiding this comment.
It was a bit tricky because of two github clients. I needed to expose tokens.rs to reuse it in api/github.
cuba0001
force-pushed
the
private-repos
branch
from
August 13, 2026 22:31
03dec8b to
5626f10
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #2654