Partial libs team refactor: merge libs and libs-api, don't move libs-contributors into libs yet - #2683
Open
clarfonthey wants to merge 1 commit into
Open
Partial libs team refactor: merge libs and libs-api, don't move libs-contributors into libs yet#2683clarfonthey wants to merge 1 commit into
clarfonthey wants to merge 1 commit into
Conversation
clarfonthey
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
marcoieni and
ubiratansoares
as code owners
August 16, 2026 23:56
Member
|
Hm, I was expecting just the crates.io permission removals -- I think that's the only piece that needs doing before we can just merge the other PR? I guess we can merge this though since it's a more minimal expansion in practice... |
Dry-run check results |
clarfonthey
force-pushed
the
libs-partial-refactor
branch
from
August 17, 2026 00:03
74059a5 to
6757ac9
Compare
Contributor
Author
|
Sure: #2684 |
…contributors into libs yet
clarfonthey
force-pushed
the
libs-partial-refactor
branch
from
August 17, 2026 13:30
6757ac9 to
99b4987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was a request from @Mark-Simulacrum.
Essentially, this is #2651 without the merging of libs-contributors into libs, which is blocked by removing team access to crates for libs. It does technically give access to two additional people for these crates (BurntSushi and dtolnay) as they were only part of libs-api before, but this is fine comparing to giving 21 additional people access (assuming I counted right).