docs(agents): consolidate AGENTS.md and align skills with latest prompt guidelines - #196
Merged
Merged
Conversation
…pt guidelines - Deduplicate AGENTS.md (327 -> 135 lines): merge three overlapping quality-check/testing sections, drop generic template boilerplate - Fix commands to match package.json scripts (pnpm type-check, format:check); document that test:run only picks up tests/lib - Add rules: PR screenshot diffs for user-visible changes, multi-role adversarial verification, concise/elegant code, unified UI style - ui-audit skill: align quality gates with repo scripts, concretize browser validation tooling, reuse captures as PR screenshot diffs - design-guide skill: cross-reference ui-audit and PR screenshot rule - Keep nextjs-agent-rules block byte-identical; leave vendored shadcn skill untouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A round of optimization over all agent prompts and skills to match current LLM prompt/skill authoring guidelines (concise, non-redundant, imperative, accurate to the repo).
AGENTS.md (327 → 135 lines):
package.jsonscripts:pnpm type-check(runs theme overrides + tsc) instead ofpnpm tsc --noEmit; addedpnpm format:check.test:runonly picks uptests/lib/*.test.{js,ts}— suites elsewhere silently never run.nextjs-agent-rulesblock kept byte-identical.skills/ui-audit/SKILL.md: quality gates aligned with repo scripts (incl.
nvm use v22); vague "preferred browser automation surface" made concrete; audit captures explicitly reused as the PR screenshot diff.skills/rustfs-console-design-guide/SKILL.md: reciprocal cross-reference with ui-audit; review-workflow captures tied to the PR screenshot-diff requirement.
Vendored
.agents/skills/shadcn/intentionally untouched (maintained by shadcn CLI).Verified via an adversarial reviewer pass diffing old vs new AGENTS.md: 5 dropped rules found and restored (TODO-with-issue-number,
pnpm start, plan-doc stage format, single responsibility, one-assertion-per-test); commands, frontmatter, cross-referenced paths, and the Next.js block all check out.Type of Change
Testing
Docs-only change.
pnpm prettier --checkpasses on all three touched files; all referenced commands and file paths verified againstpackage.jsonand the repo.Checklist
Related Issues
N/A
Screenshots (if applicable)
N/A — no user-visible UI change.
Additional Notes
None.