fix(auth): preserve 401 status for expired JWTs in OTel traces - #2
Open
ryan-crabbe wants to merge 1 commit into
Open
fix(auth): preserve 401 status for expired JWTs in OTel traces#2ryan-crabbe wants to merge 1 commit into
ryan-crabbe wants to merge 1 commit into
Conversation
Expired JWT access tokens raised a bare Exception("Token Expired") with
no status code. That codeless exception was logged to OpenTelemetry (via
post_call_failure_hook) before auth_exception_handler re-wrapped it into a
ProxyException(401), so get_error_information extracted an empty error_code
and the OTel span never set http.response.status_code — leaving only
StatusCode.ERROR, which trace viewers render as a generic 500. The client
still received a 401, so traces and responses diverged.
Raise a ProxyException(code=401, type=expired_key) at the source in both
JWT decode paths so the 401 is preserved end-to-end (client response and
OTel http.response.status_code), matching the virtual-key expiry behavior.
https://claude.ai/code/session_016kg8zDKSZ3ftywjX69uAYH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expired JWT access tokens raised a bare Exception("Token Expired") with
no status code. That codeless exception was logged to OpenTelemetry (via
post_call_failure_hook) before auth_exception_handler re-wrapped it into a
ProxyException(401), so get_error_information extracted an empty error_code
and the OTel span never set http.response.status_code — leaving only
StatusCode.ERROR, which trace viewers render as a generic 500. The client
still received a 401, so traces and responses diverged.
Raise a ProxyException(code=401, type=expired_key) at the source in both
JWT decode paths so the 401 is preserved end-to-end (client response and
OTel http.response.status_code), matching the virtual-key expiry behavior.
https://claude.ai/code/session_016kg8zDKSZ3ftywjX69uAYH