Fix for #48 (items duping upon assembly/disassembly)#365
Open
aphom wants to merge 14 commits intoryanhcode:mainfrom
Open
Fix for #48 (items duping upon assembly/disassembly)#365aphom wants to merge 14 commits intoryanhcode:mainfrom
aphom wants to merge 14 commits intoryanhcode:mainfrom
Conversation
…oject#315 Creators-of-Aeronautics/Simulated-Project#329 Only for assembling. Fix for disassembling will be requested on Aeronautics' side.
Author
|
There are still issues with these blocks listed below that allow placement of brittle blocks, as they also have the "wrench_pickup" tag, so they mess up the sorting because they are included in the list of brittle blocks.. so the dupe bug still happens with them. Not sure how to fix this as of right now without manually making a specific list of blocks that should be excluded from the brittle blocks list, which would probably not be feasible because of other addons' blocks.
From some testing it seems that these blocks mostly have issues while disassembling. *This is no longer an issue with the new fix implementation. |
…mplemented on Aero's side as well. This fix on Sable's side fixes both for assembly and disassembly.
… replaced with barriers first, which fully prevents any brittle blocks from breaking.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rudimentary fix for items duping upon assembly and disassembly.
Closes #48, closes Creators-of-Aeronautics/Simulated-Project#315, closes Creators-of-Aeronautics/Simulated-Project#329, closes Creators-of-Aeronautics/Simulated-Project#94
The old blocks that were being assembled / disassembled are first temporarily replaced by barriers to prevent brittle blocks from breaking prematurely, then they are replaced by air to complete the assembly / disassembly, which fixes the issue with certain items duping.
Before the fix is applied:

After the fix is applied:
