SampleRate methods for ios - #190
Open
MarkusKnochKenbun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the awesome package first of all!
For my use case I could really need some methods to set the preferred sample rate and to check on it. I have no experience in swift or objective c at all so the suggested addition has all been generated.
I'm also not quiet sure about the downstream effects of changing the preferred sample rate, but I need 16kHz for my machine learning pipeline use case. I use it in a flutter app with flutter_rust_bridge, in which I do multiplatform audio recording with cpal and sadly ios only gives me 48kHz.
I can always resample down the line in my hotpath but handling it to the source seems more elegant to me. I tested it on my iphone 12 and it seems to work.