Repository navigation
Replace replay-based oracles and simplify numerical alignment - #440
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca83ff4d11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace alignment paths that replayed oracle outputs or reused native transition logic with independent official computations. Use ordinary native sampling and math, and check semantic hidden state before transferring it to the oracle. Keep native determinism and unsynchronized randomization checks separate.
This follows #432 and the existing MountainCar/HalfCheetah/DMC state-transfer pattern.
AGENTS.mdand the new-environment guide document the validation contract. Execution plans stay local.Types of changes
Implemented Tasks
third_party/myosuite. Share probe launcher lookup and subprocess/JSON/error handling, while retaining each caller’s mode, seed and rendering parameters. Serialize hidden-state arrays from direct model dimensions. Isolate each probe’s intermediate coverage database while preserving LCOV aggregation.__version__from 1.2.7 to 1.2.8 after the preceding full CI checkpoint passed.Saved-frame and model experiments distinguish harmless roundoff from state/render defects. Numerical budgets remain scoped to the affected quantities. The subsequent consolidation preserves existing numerical/image budgets and rollout lengths. Jumanji uses its pinned Minesweeper state schema, and unused helpers/accessors are removed.
Validation
Final head
0689d2b525177a9d76f482ac6686a1ed200213b2passed:Focused evidence for the final validation fixes:
Complete final job logs and checksums are archived locally. The task devbox and temporary diagnostic branches were removed after their evidence was saved. Version metadata is consistently 1.2.8; no package or tag was published.
Review and remaining decision
Craftax's compact Threefry/key-sequence core remains. Retaining it or replacing it with further semantic-state validation is still an open user decision. This regular PR remains unmerged.