Repository navigation
test: move the demo app and its e2e bench into this repository - #1
Merged
Merged
Conversation
The bench used to live in a private repository, so nobody outside could rerun it. demo/ is the app from sakuga-software/headless-cms-templates, as a workspace member that depends on the adapter with workspace:*. It imports the adapter from dist/, so pnpm build runs first. - React, Payload, @payloadcms/ui, React Router, Vite and @vitejs/plugin-rsc resolve to one copy for the adapter and the demo. The root gets react-server-dom-webpack and the demo gets esbuild 0.28 to align their peer sets: with two copies of @vitejs/plugin-rsc the adapter would import a different runtime than the one the demo builds with. - CI runs the bench on the production build and on vite dev, and checks that demo/ stays out of the package. - README and COMPAT describe the 35 scenarios and the commands to run them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the demo app and its 35-scenario Playwright bench into this repository, so anyone can rerun them. Until now they lived in a private repository.
What changes
demo/: the Payload 4 + React Router 8 app (SQLite, Lexical, drafts and autosave, page blocks with live preview, uploads, two locales, a global, a website on the Local API). It is a pnpm workspace member that depends on the adapter withworkspace:*, and it imports the adapter fromdist/.@payloadcms/ui, React Router, Vite and@vitejs/plugin-rscresolve to the same path for the adapter and the demo. The root addsreact-server-dom-webpackand the demo addsesbuild@^0.28to align their peer sets. Otherwise the adapter would import a second@vitejs/plugin-rscruntime, which a published install never does.e2ejob on the production build and onvite dev. Thechecksjob fails ifdemo/ends up in the package.docs/COMPAT.mdlist the 35 scenarios and the commands.Checked locally
pnpm typecheck,pnpm test(16 unit tests),pnpm build.vite dev.pnpm pack --dry-run:dist/, README, LICENSE and package.json only.🤖 Generated with Claude Code