Repository navigation
fix: patch react-router 8.4.0 so an aborted request cannot stop the server - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In RSC mode,
react-router8.4.0 can stop the Node process when a client aborts a document request (TypeError: Invalid state: Unable to enqueue, unhandled rejection). Reported upstream as remix-run/react-router#15611, with a proposed fix in remix-run/react-router#15612.What changes
patches/react-router@8.4.0.patch(pnpm patch): the exact fix from fix(react-router): stop the RSC HTML stream when it is cancelled during flush remix-run/react-router#15612, as React Router's build emits it, indist/{development,production}/lib/rsc/html-stream/server.js. No other file of the package changes.pnpm-workspace.yaml:patchedDependencies, so the demo, the bench and CI use the patched build.filesisdistonly), so the README explains how to add it.Remove the patch when a React Router release contains the fix.
Verification
Production build of
demo/,react-router-serve, one request at a time that the client aborts after 1–9 ms (/answers in about 6 ms), capped at 300:pnpm install --frozen-lockfile, the library build and the demo build pass with the patch.