Repository navigation
fix: follow the upstream review of the react-router 8.4.0 patch - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
patches/react-router@8.4.0.patchto match the latest commit of remix-run/react-router#15612:writeRSCStreamfails, itsfinallyreleases the reader.stop()could then not cancel the RSC stream, so the RSC render kept running for nothing (no crash).stop()now callsrscStream.cancel()when the stream is no longer locked.tee()branch, and its cancel waits for the other branch.stop()now unblocksflush()before it cancels the RSC stream. Before this, an abort duringflush()kept the response open until the RSC render ended.Verification on the demo production build, with requests that the client aborts after 1–30 ms: