Skip to content

refactor(workbench): move dev-server registration into workbench-cli#1337

Draft
gu-stav wants to merge 1 commit into
refactor/workbench-move-interfacesfrom
refactor/workbench-move-registration
Draft

refactor(workbench): move dev-server registration into workbench-cli#1337
gu-stav wants to merge 1 commit into
refactor/workbench-move-interfacesfrom
refactor/workbench-move-registration

Conversation

@gu-stav

@gu-stav gu-stav commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Registration drives the registry, so it belongs beside it; the CLI now injects only what it owns — the resolved app id and the manifest extractor — keeping workbench-cli free of CLI config/manifest conventions.

What to review

The injected appId/extractManifest seam on startDevServerRegistration, and the deprecated-id check moving up to the caller.

Testing

Registration + manifest-watcher unit tests moved with the code; the deprecation tests are relocated to the devAction suite.

Registration drives the registry, so it belongs beside it; the CLI now
injects only what it owns — the resolved app id and the manifest
extractor — keeping workbench-cli free of CLI config/manifest conventions.
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Stats — @sanity/cli

Compared against refactor/workbench-move-interfaces (e7023362)

@sanity/cli

Metric Value vs refactor/workbench-move-interfaces (e702336)
Internal (raw) 2.7 KB -
Internal (gzip) 1.0 KB -
Bundled (raw) 11.15 MB -
Bundled (gzip) 2.10 MB -
Import time 500ms +5ms, +1.0%

bin:sanity

Metric Value vs refactor/workbench-move-interfaces (e702336)
Internal (raw) 782 B -
Internal (gzip) 423 B -
Bundled (raw) 9.87 MB -
Bundled (gzip) 1.77 MB -
Import time 1.15s +6ms, +0.5%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — @sanity/cli-core

Compared against refactor/workbench-move-interfaces (e7023362)

Metric Value vs refactor/workbench-move-interfaces (e702336)
Internal (raw) 106.7 KB -
Internal (gzip) 26.7 KB -
Bundled (raw) 21.71 MB -
Bundled (gzip) 3.45 MB -
Import time 437ms +12ms, +2.8%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — create-sanity

Compared against refactor/workbench-move-interfaces (e7023362)

Metric Value vs refactor/workbench-move-interfaces (e702336)
Internal (raw) 908 B -
Internal (gzip) 483 B -
Bundled (raw) 931 B -
Bundled (gzip) 491 B -
Import time ❌ ChildProcess denied: node -
Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Delta

File Statements
packages/@sanity/cli/src/actions/dev/devAction.ts 52.2% (- 3.2%)
packages/@sanity/cli/src/actions/dev/workbench/startWorkbenchDevServer.ts 98.8% (- 0.1%)
packages/@sanity/cli/src/actions/manifest/extractStudioManifest.ts 20.0% (new)
packages/@sanity/workbench-cli/src/actions/dev/deriveInterfaces.ts 100.0% (new)
packages/@sanity/workbench-cli/src/actions/dev/interfaceSetId.ts 100.0% (new)
packages/@sanity/workbench-cli/src/actions/dev/startDevManifestWatcher.ts 89.4% (new)
packages/@sanity/workbench-cli/src/actions/dev/startDevServerRegistration.ts 100.0% (new)

Comparing 7 changed files against main @ bf9fcfcc54c39ac346699e7a33b1b0919a429bfe

Overall Coverage

Metric Coverage
Statements 87.7% (+ 0.6%)
Branches 77.4% (+ 0.5%)
Functions 87.1% (+ 1.3%)
Lines 88.1% (+ 0.6%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant