refactor(workbench): orchestrate the workbench dev run in workbench-cli#1339
Draft
gu-stav wants to merge 1 commit into
Draft
refactor(workbench): orchestrate the workbench dev run in workbench-cli#1339gu-stav wants to merge 1 commit into
gu-stav wants to merge 1 commit into
Conversation
devAction was a 240-line orchestrator carrying the workbench lock, app-server supervision, registry wiring, and signal teardown. Move all of it into a `startWorkbenchDev` entry the CLI delegates to, leaving devAction a small dispatcher that injects the CLI-domain pieces and lazy-loads the package so a plain `sanity dev` never touches it.
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs refactor/workbench-move-dev-server (92b1d6e) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 1.0 KB | - |
| Bundled (raw) | 11.15 MB | - |
| Bundled (gzip) | 2.10 MB | - |
| Import time | 886ms | +18ms, +2.0% |
bin:sanity
| Metric | Value | vs refactor/workbench-move-dev-server (92b1d6e) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 1.98s | +8ms, +0.4% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against refactor/workbench-move-dev-server (92b1d6e5)
| Metric | Value | vs refactor/workbench-move-dev-server (92b1d6e) |
|---|---|---|
| Internal (raw) | 106.7 KB | - |
| Internal (gzip) | 26.7 KB | - |
| Bundled (raw) | 21.71 MB | - |
| Bundled (gzip) | 3.45 MB | - |
| Import time | 786ms | +12ms, +1.5% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against refactor/workbench-move-dev-server (92b1d6e5)
| Metric | Value | vs refactor/workbench-move-dev-server (92b1d6e) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 12 changed files against main @ Overall Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
devAction had grown into a ~240-line orchestrator carrying the workbench lock, app-server supervision, registry wiring, and signal teardown — moving all of it into one
startWorkbenchDeventry leaves devAction a small dispatcher that injects the CLI-domain pieces and lazy-loads the package, so a plainsanity devnever touches workbench-cli.What to review
The new
startWorkbenchDev+appServerSupervisor, the slimmed devAction dispatcher, andworkbenchAvailable→announceUrl. One behaviour delta: teardown is now a sequential reverse unwind (was a parallelallSettled), which keeps the watcher stopping before the app server closes.Testing
Orchestration tests moved to
startWorkbenchDev/appServerSupervisor; devAction tests now cover the dispatch + injection.