Skip to content

feat: exclude Mac metadata with optional Windows filename checks #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
athousanddetails wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: exclude Mac metadata with optional Windows filename checks #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df9e7ce
feat: add optional metadata exclusion and Windows filename checks
athousanddetails Oct 3, 2026
ccad0b7
fix: validate generated metadata names before writing
athousanddetails Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions MacPacker/Features/Settings/GeneralSettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ struct GeneralSettingsView: View {
@AppStorage(Keys.rememberRecentArchives) var rememberRecentArchives: Bool = true
@AppStorage(Keys.smartExtraction, store: .macPackerShared) var smartExtraction: Bool = true

@AppStorage(Keys.excludeMacMetadata) var excludeMacMetadata = false
@AppStorage(Keys.requireWindowsCompatibleNames) var requireWindowsCompatibleNames = false

var body: some View {
VStack(spacing: 8) {
HStack(alignment: .top) {
Expand Down Expand Up @@ -119,6 +122,27 @@ struct GeneralSettingsView: View {
.padding(.leading, 8)
.frame(width: 240, alignment: .leading)
}
HStack(alignment: .top) {
Text("Exclude Mac-specific metadata", comment: "Global compression setting label")
.frame(width: 200, alignment: .trailing)
VStack(alignment: .leading, spacing: 4) {
Toggle(isOn: $excludeMacMetadata) { EmptyView() }
.labelsHidden()
.accessibilityIdentifier("settings.excludeMacMetadata")
Toggle(isOn: $requireWindowsCompatibleNames) {
Text("Windows-compatible filenames", comment: "Optional filename validation under the metadata exclusion setting")
}
.accessibilityIdentifier("settings.windowsCompatibleNames")
.help(Text("Stops before saving and lists incompatible or conflicting filenames. Files are never renamed.", comment: "Help for the Windows-compatible filename validation setting"))
.disabled(!excludeMacMetadata)
Text("Leaves out .DS_Store, resource forks and Finder metadata when compressing or saving. Hidden flags and custom folder icons are not preserved.", comment: "Consequences of excluding Mac metadata from archives")
.font(.caption)
.foregroundStyle(.secondary)
.fixedSize(horizontal: false, vertical: true)
}
.padding(.leading, 8)
.frame(width: 240, alignment: .leading)
}
}
.padding()
// Turning it off is a privacy switch, so what was collected goes with it —
Expand Down
Loading