Repository navigation
lang: Add Greek localization - #298
Camthalion77 wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughGreek translations were added to the app’s string catalogs and archive-related modules. The Xcode project now lists Greek as a known localization region. ChangesGreek localization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to This adds Greek translations and registers Greek as a supported language. No functional risk was found, so it looks safe to merge. The maintainers may want to confirm that the Greek strings follow the project's POEditor workflow. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Camthalion77 , thank you for the PR, but as you noted already, the translations are handled through POEditor. I am not able to review translations in any other language than English or German. I have to rely on translations contributors to translate correctly. POEditor is better for that than using GitHub commits (it does not require everyone to understand and use git). Furthermore, import of that large amount of data into POEditor imposes a risk of overwriting texts in other languages. That's why I only add terms, but not translations anymore (yep, I fell into this trap a year ago). Therefore, I'd like to ask you to use POEditor to add Greek language. And then I'm happy to include it with the next version. Thank you! |
|
@sarensw Hi Stephan, |
|
@Camthalion77 Thank you very much. Can't wait to bring Greek to MacPacker with v1.1 then. |
Summary
Adds complete Greek (
el) localization support for MacPacker.elin the Xcode project known regionsVerification
Manually verified on macOS after initializing the repository submodules.
Build command used:
xcodebuild \ -project MacPacker.xcodeproj \ -scheme MacPacker \ -configuration Debug \ -destination 'platform=macOS' \ CODE_SIGNING_ALLOWED=NO \ buildResult:
The localization data was also checked to preserve placeholders such as
%@and%lld, including plural entries.AI assistance
This contribution was prepared with substantial AI assistance from ChatGPT/OpenAI for translation drafting, catalog editing, and validation scripts. I manually ran the changes, resolved the build prerequisites, built the project successfully, and am responsible for the submitted content.
Localization workflow note
I saw that MacPacker normally manages translations through POEditor. This PR submits the Greek localization directly so the language can be reviewed; if you prefer the Greek translations to be imported through POEditor instead, I’m happy to adapt the contribution to that workflow.
Changelog
Suggested entry for the current
1.0.1block (PR #298):{ "type": "lang", "highlight": true, "title": { "en": "Now available in Greek", "el": "Τώρα διαθέσιμο και στα Ελληνικά", "zh-Hans": "现已支持希腊语", "fr": "Désormais disponible en grec", "de": "Jetzt auch auf Griechisch", "it": "Ora disponibile anche in greco", "ja": "ギリシャ語にも対応しました", "fa": "اکنون به زبان یونانی نیز در دسترس است", "pl": "Dostępne teraz również po grecku", "pt-BR": "Agora disponível em grego", "ru": "Теперь доступно на греческом", "uk": "Тепер доступно грецькою", "es-MX": "Ahora disponible en griego", "ko": "이제 그리스어로도 제공됩니다", "nl": "Nu ook beschikbaar in het Grieks", "tr": "Artık Yunanca da mevcut", "vi": "Hiện đã có tiếng Hy Lạp" }, "issues": ["298"] }The current
1.0.1release is only tagged as beta, so this belongs in the first changelog block under the repository rules.Summary by CodeRabbit