Skip to content

lang: Add Greek localization - #298

Closed
Camthalion77 wants to merge 1 commit into
sarensw:mainfrom
Camthalion77:greek-localization
Closed

Camthalion77 wants to merge 1 commit into
sarensw:mainfrom
Camthalion77:greek-localization

Conversation

@Camthalion77

@Camthalion77 Camthalion77 commented Oct 4, 2026 •

Copy link
Copy Markdown

Summary

Adds complete Greek (el) localization support for MacPacker.

  • adds Greek translations to the main MacPacker string catalog
  • adds Greek translations to LeanBytes, Core, and ArchivePreviewUI catalogs
  • registers el in the Xcode project known regions
  • covers all 216 localized strings, including plural forms and format placeholders

Verification

Manually verified on macOS after initializing the repository submodules.

216/216 strings have Greek localizations

Build command used:

xcodebuild \
  -project MacPacker.xcodeproj \
  -scheme MacPacker \
  -configuration Debug \
  -destination 'platform=macOS' \
  CODE_SIGNING_ALLOWED=NO \
  build

Result:

** BUILD SUCCEEDED **

The localization data was also checked to preserve placeholders such as %@ and %lld, including plural entries.

AI assistance

This contribution was prepared with substantial AI assistance from ChatGPT/OpenAI for translation drafting, catalog editing, and validation scripts. I manually ran the changes, resolved the build prerequisites, built the project successfully, and am responsible for the submitted content.

Localization workflow note

I saw that MacPacker normally manages translations through POEditor. This PR submits the Greek localization directly so the language can be reviewed; if you prefer the Greek translations to be imported through POEditor instead, I’m happy to adapt the contribution to that workflow.

Changelog

Suggested entry for the current 1.0.1 block (PR #298):

{
  "type": "lang",
  "highlight": true,
  "title": {
    "en": "Now available in Greek",
    "el": "Τώρα διαθέσιμο και στα Ελληνικά",
    "zh-Hans": "现已支持希腊语",
    "fr": "Désormais disponible en grec",
    "de": "Jetzt auch auf Griechisch",
    "it": "Ora disponibile anche in greco",
    "ja": "ギリシャ語にも対応しました",
    "fa": "اکنون به زبان یونانی نیز در دسترس است",
    "pl": "Dostępne teraz również po grecku",
    "pt-BR": "Agora disponível em grego",
    "ru": "Теперь доступно на греческом",
    "uk": "Тепер доступно грецькою",
    "es-MX": "Ahora disponible en griego",
    "ko": "이제 그리스어로도 제공됩니다",
    "nl": "Nu ook beschikbaar in het Grieks",
    "tr": "Artık Yunanca da mevcut",
    "vi": "Hiện đã có tiếng Hy Lạp"
  },
  "issues": ["298"]
}

The current 1.0.1 release is only tagged as beta, so this belongs in the first changelog block under the repository rules.

Summary by CodeRabbit

  • New Features
    • Added Greek language support across the app, including interface labels, alerts, archive actions, settings, and welcome content.
    • Added Greek translations for archive previews, password prompts, and archive-operation messages.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3fbe8ad-5dc5-481d-bf6d-98099629abcb
📥 Commits

Reviewing files that changed from the base of the PR and between 518110d and 0c9c84b.

📒 Files selected for processing (5)
  • MacPacker.xcodeproj/project.pbxproj
  • MacPacker/LeanBytes.xcstrings
  • MacPacker/Localizable.xcstrings
  • Modules/Sources/ArchivePreviewUI/Localizable.xcstrings
  • Modules/Sources/Core/Localizable.xcstrings

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Greek translations were added to the app’s string catalogs and archive-related modules. The Xcode project now lists Greek as a known localization region.

Changes

Greek localization

Layer / File(s) Summary
Register Greek and localize app strings
MacPacker.xcodeproj/project.pbxproj, MacPacker/Localizable.xcstrings, MacPacker/LeanBytes.xcstrings
The project lists Greek as a known localization region. Greek translations were added to the app catalogs, including plural forms and placeholder-based strings.
Localize archive module strings
Modules/Sources/ArchivePreviewUI/Localizable.xcstrings, Modules/Sources/Core/Localizable.xcstrings
Greek translations were added for archive preview labels, password messages, and core archive statuses and names.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: sarensw

Merge Risk: ⚪ Minimal · up to 0c9c8

This adds Greek translations and registers Greek as a supported language. No functional risk was found, so it looks safe to merge. The maintainers may want to confirm that the Greek strings follow the project's POEditor workflow.

Architecture Summary

Architecture risk: 🔵 Low · up to 0c9c8

The change affects 3 systems.

Changed systems: MacPacker, Modules, MacPacker.xcodeproj

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — MacPacker (service) was modified; 2 changed files map to changed impact.
  • observed — Modules (service) was modified; 2 changed files map to changed impact.
  • observed — MacPacker.xcodeproj (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in MacPacker.xcodeproj/project.pbxproj: Added el to the project’s knownRegions localization list.
  • observed — Modified behavior in MacPacker/LeanBytes.xcstrings: Added a translated Greek localization for the FileFillet description.
  • observed — Modified behavior in MacPacker/LeanBytes.xcstrings: Added a translated Greek localization for the short FileFillet description.
  • observed — Modified behavior in MacPacker/LeanBytes.xcstrings: Added a translated Greek localization for the FlowMoose description, including its macOS 26 and 27 support wording.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding Greek localization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Camthalion77
Camthalion77 marked this pull request as ready for review October 4, 2026 03:03
@sarensw

sarensw commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Hi @Camthalion77 , thank you for the PR, but as you noted already, the translations are handled through POEditor. I am not able to review translations in any other language than English or German. I have to rely on translations contributors to translate correctly. POEditor is better for that than using GitHub commits (it does not require everyone to understand and use git). Furthermore, import of that large amount of data into POEditor imposes a risk of overwriting texts in other languages. That's why I only add terms, but not translations anymore (yep, I fell into this trap a year ago). Therefore, I'd like to ask you to use POEditor to add Greek language. And then I'm happy to include it with the next version. Thank you!

@sarensw sarensw closed this Oct 4, 2026
@Camthalion77

Copy link
Copy Markdown
Author

@sarensw Hi Stephan,
Greek is now fully translated in POEditor — 188/188 terms, 100%.
Thanks again for pointing me to the correct workflow. Looking forward to seeing Greek included in the next version!

@sarensw

sarensw commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@Camthalion77 Thank you very much. Can't wait to bring Greek to MacPacker with v1.1 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants