Conversation
- avoids failure on None.group(0) from input like
Gap First Sol. : infinite
Collaborator
|
This looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some corrupted .out files where ipet (in rubberband) failed with some exception in the line
misc.numericExpression.search(line, colonidx + 1)returned None, and thenNone.group()isn't good.The line to parse was
But I guess its the corruption of the out file that lead to an issue here now.
This PR adds a check that this isn't None.
I also had a problem to run the ipet-parse script, because
loggerwasn't defined in theprocess_one_outfiles_group()function.