fix: require patched Go version for CVE-2023-39318 - #324
Open
Akash3121 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Akash Reddy Jammula <akashreddyjammula@gmail.com>
Author
|
Hi @mathieu, I'm planning to address vulnerabilities reported in LFX Insights. This is the first fix - please review it when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation?
CVE-2023-39318 / GO-2023-2041 is reported for this repository on the LFX Insights security page because go.mod declares Go 1.19.
The vulnerability affects Go’s html/template package. Versions before Go 1.20.8 can improperly handle HTML-like and hashbang comments inside <script> contexts, potentially causing incorrect contextual escaping and cross-site scripting under specific template conditions.
This is one of several LFX Insights findings. I will address other vulnerabilities in seperate focused pull requests.

What does this change do?
Updates the minimum Go version declared in go.mod to 1.20.8
Go 1.20.8 is the first patched release in the Go 1.20 series for CVE-2023-39318.
This is intentionally a minimal change. It does not update Hugo, Docsy, module dependencies, generated documentation, or lockfiles. The repository’s locked Hugo Extended 0.123.8 binary was built with Go 1.22.0 and already contains the corrected html/template implementation. This change aligns the module’s declared minimum Go version with a patched release and addresses the version-based LFX Insights finding.
What is your testing strategy?
Is this related to any issues?
Have you read the Contributing Guidelines?