Skip to content

Further improve support for escape sequences - #37

Open
Roslund wants to merge 9 commits into
scottrhoyt:masterfrom
Roslund:master
Open

Further improve support for escape sequences#37
Roslund wants to merge 9 commits into
scottrhoyt:masterfrom
Roslund:master

Conversation

@Roslund

@Roslund Roslund commented Aug 7, 2019

Copy link
Copy Markdown
Contributor

To address the issues in #5 that @travispaul had, I've updated the striping pattern to be shorter (possibly faster?) and catch bold and underline escape sequences.
I've also added three aditional cases for the stripping test

@eneko eneko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the update, @Roslund 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants