Skip to content

WIP: feat(jax): Add JAX export kernel#246

Open
oeqqwq wants to merge 3 commits into
mainfrom
ar/jax_export
Open

WIP: feat(jax): Add JAX export kernel#246
oeqqwq wants to merge 3 commits into
mainfrom
ar/jax_export

Conversation

@oeqqwq
Copy link
Copy Markdown
Member

@oeqqwq oeqqwq commented Nov 10, 2025

No description provided.

@oeqqwq oeqqwq requested a review from a team as a code owner November 10, 2025 03:28
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @oeqqwq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates JAX's export functionality, allowing JAX computations to be compiled into a portable, serialized format for remote execution. This new capability provides a flexible mechanism for offloading JAX functions, enhancing the system's distributed computing potential by decoupling JAX function definition from its execution environment.

Highlights

  • JAX Export Kernel: A new kernel jax_xla has been introduced, enabling the execution of JAX functions that have been compiled into a portable export format.
  • jax.exec Kernel ID: The jax.exec kernel ID is now registered, allowing the system to dispatch JAX exported functions for execution.
  • JAX Function Serialization: A new jax_export function is added to compile JAX functions into a serialized PFunction object, including type metadata and the base64-encoded JAX export data.
  • Dependency Updates: absl-py and flatbuffers have been added as new project dependencies to support JAX's export and serialization capabilities.
  • Comprehensive Testing: Extensive unit tests have been added for both the jax_export frontend and the _jax_exec kernel, covering various scenarios including different data types, shapes, multiple outputs, and error handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new JAX export kernel, providing a modern and portable way to execute JAX functions. The changes include a new kernel implementation (jax_xla.py), a corresponding frontend compilation function (jax_export in jax_cc.py), and comprehensive unit and integration tests. The implementation is well-structured and robust. I've provided a few suggestions in mplang/kernels/jax_xla.py to improve code clarity and maintainability by refactoring some of the data conversion logic and making exception handling more specific. Overall, this is a great addition.

Comment thread mplang/kernels/jax_xla.py Outdated
Comment thread mplang/kernels/jax_xla.py Outdated
Comment thread mplang/kernels/jax_xla.py
@oeqqwq oeqqwq changed the title feat(jax): Add JAX export kernel WIP: feat(jax): Add JAX export kernel Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant