Conversation
…provider Add support for CyberArk Conjur as an Enterprise-tier external secret storage backend for project access keys and environment secrets. - Add SecretStorageTypeCyberArk constant and deserializer stub in pro module - Route CyberArk storage type in access key encryption service - Add UI for configuring CyberArk Conjur (URL, account, login, API key) - Register CyberArk icon and menu entry under Enterprise secret storages Co-authored-by: Denis Gukov <fiftin@outlook.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CyberArk Conjur as an Enterprise-tier external secret storage provider for project access keys and environment secrets, addressing PRO-1 for DICK'S Sporting Goods.
Changes
SecretStorageTypeCyberArk(cyberark) constant and a Pro module deserializer stub following the same pattern as AWS Secrets Manager, Azure Key Vault, and Devolutions ServerAccessKeyEncryptionService.getDeserializer()so keys stored in CyberArk Conjur are resolved at runtimeNotes
The Pro module deserializer is a stub in this OSS repository; the actual CyberArk Conjur REST API integration (authenticate via
/authn/{account}/login, retrieve secrets via/secrets/{account}/variable/{identifier}) will be implemented in the Enterprise codebase.CyberArk Conjur is gated behind the
secret_storage_management_exEnterprise feature flag, consistent with other Enterprise providers.Testing
go test ./services/server/... -count=1— passgo test ./services/project/... -run TestBackup -count=1— passLinear Issue: PRO-1