Skip to content

Avoid ghc-prim dependency & fix git link - #302

Merged
gromakovsky merged 1 commit into
serokell:masterfrom
konsumlamm:master
Mar 3, 2026
Merged

gromakovsky merged 1 commit into
serokell:masterfrom
konsumlamm:master

Conversation

@konsumlamm

Copy link
Copy Markdown
Contributor

Description

Avoid depending on ghc-prim by using GHC.Base instead of GHC.Types and fix the git link in the source-repository section.

✓ Checklist for your Pull Request

  • I made sure my PR addresses a single concern, or multiple concerns which
    are inextricably linked. Otherwise I should open multiple PR's.
  • If I added/removed/deprecated functions/re-exports,
    I checked whether these changes impact the .hlint.yaml rules
    and updated them if needed.

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    I checked whether I should update the docs and did so if necessary:

  • Record your changes

    • I added an entry to the changelog (creating the Unreleased section if necessary) if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

  • My commit history is clean (only contains changes relating to my
    issue/pull request and no reverted-my-earlier-commit changes) and commit
    messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been
    made/pushed using rebase and squash.

✓ Release Checklist

  • I updated the version number in universum.cabal.
  • I updated the changelog and moved everything
    under the "Unreleased" section to a new section for this release version.
  • If any definitions (functions, type classes, instances, etc) were added,
    I added @since haddock annotations.
  • (After merging) I created a new entry in the releases page,
    with a summary of all user-facing changes.
    • I made sure a tag was created using the format vX.Y.Z

@konsumlamm

Copy link
Copy Markdown
Contributor Author

@gromakovsky

@int-index int-index left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks!

@gromakovsky

Copy link
Copy Markdown
Member

For some reason CI doesn't run here. Could you try merging/rebasing onto latest master (I've just merged another PR)? Maybe it will trigger CI.

@konsumlamm

Copy link
Copy Markdown
Contributor Author

I rebased on latest master, but I think a maintainer needs to approve the CI run first, since this is my first contribution. See https://github.com/serokell/universum/actions/runs/22585587434.

@int-index

Copy link
Copy Markdown
Member

I think a maintainer needs to approve the CI run first

There was no button to do so prior to the rebase, but this time I've been able to approve the CI run.

@gromakovsky
gromakovsky merged commit faacef1 into serokell:master Mar 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants