Avoid ghc-prim dependency & fix git link - #302
Merged
Merged
Conversation
Contributor
Author
Member
|
For some reason CI doesn't run here. Could you try merging/rebasing onto latest |
Fix git link
Contributor
Author
|
I rebased on latest |
Member
There was no button to do so prior to the rebase, but this time I've been able to approve the CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid depending on
ghc-primby usingGHC.Baseinstead ofGHC.Typesand fix the git link in thesource-repositorysection.✓ Checklist for your Pull Request
are inextricably linked. Otherwise I should open multiple PR's.
I checked whether these changes impact the
.hlint.yamlrulesand updated them if needed.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Unreleasedsection if necessary) if my changes are visible to the usersand
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
✓ Release Checklist
universum.cabal.under the "Unreleased" section to a new section for this release version.
I added
@sincehaddock annotations.with a summary of all user-facing changes.
vX.Y.Z