Skip to content

Add CLI parameters for ePBS builder configuration (#10185) - #10374

Open
0xfornax wants to merge 1 commit into
sigp:unstablefrom
0xfornax:codex/feat-builder-cli-flags
Open

0xfornax wants to merge 1 commit into
sigp:unstablefrom
0xfornax:codex/feat-builder-cli-flags

Conversation

@0xfornax

@0xfornax 0xfornax commented Oct 16, 2026 •

Copy link
Copy Markdown

Issue Addressed

Implements #10185.

Proposed Changes

  • Adds --builder-urls, --builder-min-bid, and --builder-max-execution-payment for Gloas, and wires the existing --builder-boost-factor into the builder configuration.

  • CLI settings will be a fallback for global YAML defaults, preserving Add per-validator builder configuration API #9864 's per-validator precedence and persistence behavior. The order is: per-validator YAML > global YAML > CLI > defaults.

AI assistance

This PR was AI-assisted, but I understand the changes and have tested them thoroughly on a local kurtosis network.

@cla-assistant

cla-assistant Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Oct 16, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@0xfornax
0xfornax force-pushed the codex/feat-builder-cli-flags branch from 48ddaad to 2859072 Compare October 16, 2026 17:35
@0xfornax
0xfornax marked this pull request as ready for review October 16, 2026 17:36

@pawanjay176 pawanjay176 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @0xfornax . The code looks good to me.
My concern is more about policy.

This PR effectively overwrites global builder urls, and other configs with cli params.

This means that you could accidentally delete a config by passing cli params. I think this is okay as long as this is documented. But in terms of actual users, I'm not sure how they would use this.
A potential change in policy is just appending the cli params to the config and throwing an error only if the same builder is present in both lists with different configs.

I would defer to you and @yorickdowne as to which is the better policy based on your experience with users.

@michaelsproul

Copy link
Copy Markdown
Member

For consistency with the rest of Lighthouse, the CLI params should be the default/fallback for the case where no value is specified in the config. I think we should keep that the same here unless there's a very good reason to change it.

@0xfornax
0xfornax force-pushed the codex/feat-builder-cli-flags branch from 2859072 to a2f01eb Compare October 17, 2026 00:06
@0xfornax

Copy link
Copy Markdown
Author

Thanks for the feedback @michaelsproul and @pawanjay176!

I've adjusted the precedence so it's: Per-validator YAML > global defaults YAML > CLI.

@yorickdowne

Copy link
Copy Markdown

Per-validator yaml likely also covers per-validator keymanager. Just pointing out to please make sure it’s at that level of precedence and doesn’t get overriden by CLI

@michaelsproul

Copy link
Copy Markdown
Member

yeah keymanager writes to the config so it is one and the same

@0xfornax
0xfornax force-pushed the codex/feat-builder-cli-flags branch from a2f01eb to 45e7446 Compare October 19, 2026 16:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants