Repository navigation
Visualize float16 datasets - #2045
Merged
Merged
Conversation
Contributor
Author
|
@axelboc : Had to alias to Uint16 until this is resolve. Also this PR depends on usnistgov/h5wasm#141, so no merge until then. |
NAThompson
force-pushed
the
float16-support
branch
from
August 28, 2026 16:58
e8c96ea to
2265e14
Compare
Contributor
Author
|
@loichuder , @axelboc : The h5wasm MR has been merged-this is ready for review. |
axelboc
force-pushed
the
float16-support
branch
from
September 18, 2026 13:58
2265e14 to
4f3c230
Compare
axelboc
reviewed
Sep 18, 2026
Contributor
|
`isTypedArray` did not recognize `Float16Array`, so half-precision values were rejected outright even though `parseDType` already labelled the datasets float16. The check goes through `globalThis` because naming the constructor directly would throw a `ReferenceError` on older runtimes. Heatmaps view the halves as uint16 rather than widening them to float32, so they upload as a HALF_FLOAT texture -- already supported here -- with no conversion pass and half the texture memory.
axelboc
force-pushed
the
float16-support
branch
from
September 18, 2026 14:08
4f3c230 to
7559358
Compare
Contributor
|
Next steps will be to upgrade h5wasm once released, and to make sure the h5grove and HSDS providers return |
loichuder
approved these changes
Sep 28, 2026
Contributor
Author
|
@loichuder , @axelboc : Did the h5wasm release get cut? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isTypedArraydid not recognizeFloat16Array, so half-precision values were rejected outright even thoughparseDTypealready labelled the datasets float16. The check goes throughglobalThisbecause naming the constructor directly would throw aReferenceErroron older runtimes.Heatmaps view the halves as uint16 rather than widening them to float32, so they upload as a HALF_FLOAT texture -- already supported here -- with no conversion pass and half the texture memory.