Skip to content

fix: initialize screen with disabled panel offset #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simmsb merged 1 commit into from
Aug 17, 2026
Merged

fix: initialize screen with disabled panel offset #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion inkview/src/screen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::bindings::APPLICATION_ATTRIBUTE_APPLICATION_READER;
use crate::bindings::{APPLICATION_ATTRIBUTE_APPLICATION_READER, PANEL_FLAGS_PANEL_NO_FB_OFFSET};
use crate::error;
use crate::{bindings::icanvas_s, bindings::Inkview};
use core::ffi::c_int;
Expand Down Expand Up @@ -177,6 +177,9 @@ impl<'a, P> Screen<'a, P> {
unsafe {
iv.SetCurrentApplicationAttribute(APPLICATION_ATTRIBUTE_APPLICATION_READER, 1);
}
unsafe {
iv.SetPanelType(PANEL_FLAGS_PANEL_NO_FB_OFFSET as c_int);
}
// On the emulator the task framebuffer is null, so fall back to the global
// canvas (GetCanvas) — the same `icanvas_s`, populated in both environments.
// We do this with a plain null-check so it also recovers if a real task
Expand Down
Loading