Repository navigation
Conversation
Reworks the kappa-based bad-map rejection from #178 onto current main. ProcessableMap.finalize() now keeps a reference to kappa as `weights` (not a copy) when one was loaded. When TwoDGaussianFitter / the lmfit config is given `poor_weights: PoorWeightsCriteria`, gaussian_fit computes per-map weight percentiles and adds one of `poor_weights_center`, `poor_weights_local`, `poor_weights_extended` to the source's existing `flags` list. The fit is still attempted; nothing else changes when `poor_weights` is None (the default). Differences from #178: box sizes are angular (default 2.5'/10' half-widths, ~the original 10x10/40x40 pix at 0.5'), boxes are centered and clipped at map edges, NaN weights count as low, and the hard-coded BAD_TIMES list is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sqlmodel 0.0.45 started rejecting naive datetimes ("Datetime values must
have timezone information"), which breaks test_stacker and any
sotrplib -> mapcat write that uses Time.to_datetime() (e.g.
maps/database.py processing_start/processing_end). Pin until those
pass tz-aware UTC datetimes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the kappa-based bad-map rejection from Harlin Toor in PR #178 onto current main.
ProcessableMap.finalize() now keeps a reference to kappa as
weights(not a copy) when one was loaded. When TwoDGaussianFitter / the lmfit config is givenpoor_weights: PoorWeightsCriteria, gaussian_fit computes per-map weight percentiles and adds one ofpoor_weights_center,poor_weights_local,poor_weights_extendedto the source's existingflagslist. The fit is still attempted; nothing else changes whenpoor_weightsis None (the default).Differences from #178: box sizes are angular (default 2.5'/10' half-widths, ~the original 10x10/40x40 pix at 0.5'), boxes are centered and clipped at map edges, NaN weights count as low, and the hard-coded BAD_TIMES list is dropped.