tilemaker v3#46
Open
jernestmyers wants to merge 7 commits intomainfrom
Open
Conversation
JBorrow
requested changes
May 7, 2026
Member
JBorrow
left a comment
JBorrow
left a comment
There was a problem hiding this comment.
Sorry for the delay, GitHub PR reviews were down...
Comment on lines
+141
to
+154
| for map_group in request.app.config.map_groups: | ||
| if map_group.auth(request.auth.scopes): | ||
| for map in map_group.maps: | ||
| for band in map.bands: | ||
| for layer in band.layers: | ||
| if layer.layer_id == layer_id and map_group.auth( | ||
| request.auth.scopes | ||
| ): | ||
| return LayerWithMenuState( | ||
| **layer.model_dump(), | ||
| map_group_id=map_group.map_group_id, | ||
| map_id=map.map_id, | ||
| band_id=band.band_id, | ||
| ) |
Member
There was a problem hiding this comment.
I think this would be best done with a pass over request.app.config.layers?
Collaborator
Author
There was a problem hiding this comment.
That would require the Layer class to include the MenuState found in LayerWithMenuState. Adding a map_group_id has already invalidated old config files, so should we go ahead and refactor the generation.py logic to include the MenuState?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the API in order to minimize initial load time by sending only the minimal JSON data needed for the client's layer menu and a default baselayer. Then, as a user navigates the client's layer menu, new endpoints send summaries for maps, bands, and layers that get rendered as respective children in the menu. A search endpoint also filters map groups in the server, and sends a tree and a list of matched IDs for the client's layer menu.
Note that we now only send detailed layer data when a layer is actually selected, since the data is not necessary for the layer menu itself.