Repository navigation
Serialize YAML dates in openai endpoint list --json - #1850
Open
remote-controlled-man wants to merge 1 commit into
Open
remote-controlled-man wants to merge 1 commit into
remote-controlled-man wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unquoted YAML date such as
api_version: 2024-02-01is parsed as a Pythondate. That currently makesllm openai endpoint list --jsonraiseTypeErroron a hand-written configuration.Encode YAML date and datetime values as ISO 8601 strings in the JSON listing. The CLI regression test covers a date and a timestamp with a UTC offset.
On macOS with Python 3.12, the full pytest suite, Black, mypy, Ruff, Cog, the sdist and wheel build, and the plugin-loading smoke test passed.
OpenAI Codex assisted with investigation, implementation, and validation.