Update CODEOWNERS and stabilize fusion workspace-group drop test#128
Conversation
Add @mgiannakopoulos, @volodymyr-memsql, and @pmishchenko-ua as code owners (replacing @srinathnarayanan). Make the drop-workspace-group test tolerate eventual consistency between the per-resource and list endpoints by polling until the listed group is gone or terminated, instead of asserting immediately after WAIT ON TERMINATED. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9203a7b. Configure here.
There was a problem hiding this comment.
Pull request overview
This PR updates repository review routing via CODEOWNERS and reduces flakiness in the Fusion workspace-group drop test by adding polling to account for eventual consistency in the workspace-groups list API.
Changes:
- Adjust
CODEOWNERSentries to reflect new default owners. - Stabilize
test_create_drop_workspace_groupby polling until the dropped group disappears from the list endpoint or is marked terminated. - Add a small test helper (
_wait_workspace_group_gone) to encapsulate the polling logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
singlestoredb/tests/test_fusion.py |
Adds polling helper and uses it after workspace-group drops to avoid list-endpoint lag flakiness. |
CODEOWNERS |
Updates default owners list (currently with a precedence issue that needs correction). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- test_fusion: filter terminated rows when asserting workspace group list count, matching the wait helper's exit condition so a lingering terminated record from the previous drop doesn't skew len(wg) == 1. - CODEOWNERS: collapse four identical '*' rules into a single rule listing all four owners; CODEOWNERS uses last-match-wins, so the prior layout only routed reviews to the last-listed owner. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Summary
@srinathnarayananwith@mgiannakopoulos,@volodymyr-memsql, and@pmishchenko-uain CODEOWNERS.test_create_drop_workspace_groupby polling the workspace-groups list until the dropped group is gone or marked terminated, instead of asserting immediately afterWAIT ON TERMINATED(the list endpoint can lag behind the per-resource endpoint).Test plan
pytest singlestoredb/tests/test_fusion.py::TestWorkspaceFusion::test_create_drop_workspace_groupand it passes consistently.🤖 Generated with Claude Code
Note
Low Risk
Only CODEOWNERS routing and fusion integration-test timing/assertions change; no production library or API behavior.
Overview
Updates CODEOWNERS so the default owner line is a single entry:
@kesmit13stays,@srinathnarayananis removed, and@mgiannakopoulos,@volodymyr-memsql, and@pmishchenko-uaare added.test_create_drop_workspace_groupis adjusted for eventual consistency betweenWAIT ON TERMINATED(per-group API) andmgr.workspace_groups(list API). A new_wait_workspace_group_gonehelper polls for up to 60s until the group is missing from the list or every matching row hasterminated_atset. Post-drop checks use that helper instead of asserting an empty list immediately; post-create checks only count groups withterminated_at is Noneso stale terminated rows do not break assertions.Reviewed by Cursor Bugbot for commit bedbb8c. Bugbot is set up for automated code reviews on this repo. Configure here.