Skip to content

Update CODEOWNERS and stabilize fusion workspace-group drop test#128

Merged
kesmit13 merged 2 commits into
mainfrom
test-fusion-codeowners-update
Jun 18, 2026
Merged

Update CODEOWNERS and stabilize fusion workspace-group drop test#128
kesmit13 merged 2 commits into
mainfrom
test-fusion-codeowners-update

Conversation

@kesmit13

@kesmit13 kesmit13 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace @srinathnarayanan with @mgiannakopoulos, @volodymyr-memsql, and @pmishchenko-ua in CODEOWNERS.
  • Stabilize test_create_drop_workspace_group by polling the workspace-groups list until the dropped group is gone or marked terminated, instead of asserting immediately after WAIT ON TERMINATED (the list endpoint can lag behind the per-resource endpoint).

Test plan

  • CI runs pytest singlestoredb/tests/test_fusion.py::TestWorkspaceFusion::test_create_drop_workspace_group and it passes consistently.
  • Confirm CODEOWNERS changes route reviews to the new owners on a follow-up PR.

🤖 Generated with Claude Code


Note

Low Risk
Only CODEOWNERS routing and fusion integration-test timing/assertions change; no production library or API behavior.

Overview
Updates CODEOWNERS so the default owner line is a single entry: @kesmit13 stays, @srinathnarayanan is removed, and @mgiannakopoulos, @volodymyr-memsql, and @pmishchenko-ua are added.

test_create_drop_workspace_group is adjusted for eventual consistency between WAIT ON TERMINATED (per-group API) and mgr.workspace_groups (list API). A new _wait_workspace_group_gone helper polls for up to 60s until the group is missing from the list or every matching row has terminated_at set. Post-drop checks use that helper instead of asserting an empty list immediately; post-create checks only count groups with terminated_at is None so stale terminated rows do not break assertions.

Reviewed by Cursor Bugbot for commit bedbb8c. Bugbot is set up for automated code reviews on this repo. Configure here.

Add @mgiannakopoulos, @volodymyr-memsql, and @pmishchenko-ua as code
owners (replacing @srinathnarayanan). Make the drop-workspace-group
test tolerate eventual consistency between the per-resource and list
endpoints by polling until the listed group is gone or terminated,
instead of asserting immediately after WAIT ON TERMINATED.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9203a7b. Configure here.

Comment thread singlestoredb/tests/test_fusion.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository review routing via CODEOWNERS and reduces flakiness in the Fusion workspace-group drop test by adding polling to account for eventual consistency in the workspace-groups list API.

Changes:

  • Adjust CODEOWNERS entries to reflect new default owners.
  • Stabilize test_create_drop_workspace_group by polling until the dropped group disappears from the list endpoint or is marked terminated.
  • Add a small test helper (_wait_workspace_group_gone) to encapsulate the polling logic.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
singlestoredb/tests/test_fusion.py Adds polling helper and uses it after workspace-group drops to avoid list-endpoint lag flakiness.
CODEOWNERS Updates default owners list (currently with a precedence issue that needs correction).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CODEOWNERS Outdated
- test_fusion: filter terminated rows when asserting workspace group
  list count, matching the wait helper's exit condition so a lingering
  terminated record from the previous drop doesn't skew len(wg) == 1.
- CODEOWNERS: collapse four identical '*' rules into a single rule
  listing all four owners; CODEOWNERS uses last-match-wins, so the
  prior layout only routed reviews to the last-listed owner.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@kesmit13 kesmit13 merged commit 009869f into main Jun 18, 2026
12 checks passed
@kesmit13 kesmit13 deleted the test-fusion-codeowners-update branch June 18, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants