Repository navigation
Warn when environment passed to eval() has extra keys - #2314
Open
jeromedockes wants to merge 7 commits into
Open
jeromedockes wants to merge 7 commits into
jeromedockes wants to merge 7 commits into
Conversation
jeromedockes
added
enhancement
jeromedockes
marked this pull request as ready for review
October 6, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we now get a warning when the environment passed to eval() contains keys that don't match any variables or choices.
before, this comparison was only done when there was an error due to a missing key. however, that could result in silently using a default value (choice default or var becomes_default=True or set_name) when the user meant to override it and made a typo in the name. the check can be disabled by passing _skrub_ignore_extra_keys=True in the env. to make it easier for users to filter out all keys that have no match when they evaluate a sub-part of the dataop in the full env, #2313 should be merged first