gh: fixed go-generate cleanup to match recursively and tolerate empty grep#317
Merged
gh: fixed go-generate cleanup to match recursively and tolerate empty grep#317
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the go generate cleanup step in the goLint reusable workflow to correctly match generated .go files recursively and to avoid failing when git grep returns no matches (as referenced by the misfire from #316).
Changes:
- Updated the
git greppathspecs to match**/*.gorecursively and to exclude**/*.pb.go. - Attempted to tolerate
git grep’s “no matches” exit code during cleanup prior to runninggo generate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hslatman
previously approved these changes
May 6, 2026
hslatman
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the misfire with regards to
go generatecleanup I merged with #316.