Conversation
AnieeG
requested review from
asoliman92,
b-gopalswami,
carte7000,
matYang,
ogtownsend,
tt-cll and
winder
|
👋 AnieeG, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
tt-cll
previously approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make the lane sanity checker successfully send CCIP messages when using an EVM TestRouter, by selecting the TestRouter address and enabling a “finality” extra-args path for message sends.
Changes:
- Added a
finalityEnabledextra-arg option and started passing it during lane sanity message sends. - Updated the EVM v2.0.0 test adapter to select Router vs TestRouter via
TestRouterenv var and adjusted token approval behavior. - Updated the EVM lane sanity provider to resolve Router/TestRouter addresses and to resolve lane versions from TestRouter when enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| deployment/testadapters/adapters.go | Adds ExtraArgFinality and a helper constructor for it. |
| deployment/hooks/lane_sanity_hook.go | Passes NewFinalityExtraArg(1) when building extra args for message probes. |
| chains/evm/deployment/v2_0_0/testadapter/test_adapter.go | Adds v3 extra-args serialization path and TestRouter-aware router resolution; adjusts approvals. |
| chains/evm/deployment/hooks/lane_sanity_provider.go | Adds TestRouter-aware lane version lookup and TestRouter-aware router address resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tt-cll
approved these changes
Jun 17, 2026
|
chris-de-leon-cll
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.