test: Update secretstest mocks for slim TestResult#59
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
MockTestResultexpectations for UFM/prepareOutputpaths:ShallowMetadataCopyinstead of removed getters (GetTestSubject,GetMetadata, etc.). Production flow already relied on findings and UFM helpers.Where should the reviewer start?
internal/commands/secretstest/command_test.go—setupMockTestResultForPrepareOutputand workflow success setupHow should this be manually tested?
go test ./...Dependency / merge order
Requires GAF with CLI-1301. Drop
replaceingo.modin favor of bumpedrequirewhen GAF is published.Risk assessment
Low — test-only surface alignment.
Tickets
CLI-1301