feat: add validation for remote-repo-url, string length limits and file output paths [PS-471]#61
Open
ioannacaba wants to merge 1 commit intomainfrom
Open
feat: add validation for remote-repo-url, string length limits and file output paths [PS-471]#61ioannacaba wants to merge 1 commit intomainfrom
ioannacaba wants to merge 1 commit intomainfrom
Conversation
andreeaneata
approved these changes
Apr 9, 2026
Contributor
andreeaneata
left a comment
andreeaneata
left a comment
There was a problem hiding this comment.
Approved, but it should be a bigger conversation to have these checks done for all flows in similar ways.
Right now it cannot be done because it will introduce breaking changed for users that used --tags for IaC > x, but at the same time we might end up introducing a different behaviour for shared flags across products for Secrets.
…le output paths [PS-470]
ioannacaba
force-pushed
the
chore/PS-470/validate-user-input
branch
from
40b5b22 to
fe51d00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds validation for remote-repo-url, string length limits and file output paths.
Where should the reviewer start?
internal/commands/secretstest/validate.goHow should this be manually tested?
snyk secrets test --remote-repo-url=invalid_urlsnyk secrets test --target-name=very_very_long_stringsnyk secrets test --json-file-output=invalid_fileWhat are the relevant tickets?