fix: ignore the cli checksum when looking for clis without auto-downl…#727
Draft
fix: ignore the cli checksum when looking for clis without auto-downl…#727
Conversation
…oads (#726) If our plugin isn't managing the cli, then we never set use or compare the checksum. However, when the downloader looked for the cli, it checked for a state-stored checksum as well, and showed an error dialog if either were missing. This error doesn't stop the CLI from loading, nor does it compare the checksum (which happens elsewhere for auto-downloads). If the plugin never downloaded the cli, there's no checksum, and you get an error no matter what. Change the logic to only look for the cli existing when auto-downloads are disabled.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oads (#726)
If our plugin isn't managing the cli, then we never set use or compare the checksum. However, when the downloader looked for the cli, it checked for a state-stored checksum as well, and showed an error dialog if either were missing.
This error doesn't stop the CLI from loading, nor does it compare the checksum (which happens elsewhere for auto-downloads). If the plugin never downloaded the cli, there's no checksum, and you get an error no matter what.
Change the logic to only look for the cli existing when auto-downloads are disabled.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!