Skip to content

feat: use html settings by default [IDE-1640]#732

Open
andrewrobinsonhodges-snyk wants to merge 1 commit intomainfrom
feat/ide-1640_centralised-config-dialog
Open

feat: use html settings by default [IDE-1640]#732
andrewrobinsonhodges-snyk wants to merge 1 commit intomainfrom
feat/ide-1640_centralised-config-dialog

Conversation

@andrewrobinsonhodges-snyk
Copy link
Copy Markdown
Contributor

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Mar 19, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Restrictive Configuration Pattern 🟠 [major]

The new pattern for snyk.advanced.customEndpoint is overly restrictive. It requires the URL to start with api and end with snyk.io or snykgov.io. This will break configurations for users with private instances (Single Tenant) or internal development environments that use different domain structures, contradicting the markdownDescription which states the setting is for private instances.

"pattern": "^(|(https?://)api.*.(snyk|snykgov).io)$",
Unsafe Optional Chaining 🟡 [minor]

In the SNYK_SETTINGS_COMMAND registration, the code now calls this.workspaceConfigurationProvider?.showPanel(). If workspaceConfigurationProvider fails to initialize (e.g., due to a failure in initializeExtension), clicking the settings icon will do nothing silently, and the previous fallback to commandController.openSettings() has been removed.

await this.workspaceConfigurationProvider?.showPanel();
📚 Repository Context Analyzed

This review considered 28 relevant code sections from 13 files (average relevance: 0.63)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant