Remove snapshot version of sql-psi#882
Open
hfhbd wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the snapshot version usage of sql-psi and updates related configurations and dependencies. Key changes include:
- Adjustments to Gradle wrapper scripts to support an empty CLASSPATH and use the -jar flag.
- Updates to dependency versions and removal of a snapshot repository.
- Refinements in build logic generic type constraints.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradlew.bat | Clears CLASSPATH and updates the command to run the wrapper via -jar. |
| gradlew | Adjusts the CLASSPATH assignment and updates the execution command. |
| gradle/wrapper/gradle-wrapper.properties | Updates gradle distribution URL to a newer milestone version. |
| gradle/libs.versions.toml | Upgrades the Kotlin version to a release candidate. |
| gradle/build-logic/src/main/kotlin/zip.kt | Adds non-null constraints to generic parameters in a utility function. |
| gradle/build-logic/src/main/kotlin/myRepos.settings.gradle.kts | Removes the snapshot repository for dependency resolution. |
| gradle.properties | Removes a redundant configuration and adjusts cache settings. |
| builder/build.gradle.kts | Removes the snapshot dependency on sql-psi and related exclusion rules. |
Comments suppressed due to low confidence (4)
gradlew:117
- [nitpick] The empty CLASSPATH expression using escaped quotes may be confusing; consider simplifying it to an unambiguous empty string if supported by the runtime environment.
CLASSPATH="\"\""
builder/build.gradle.kts:12
- The removal of the snapshot dependency for sql-psi is intentional; ensure that downstream modules do not rely on the snapshot version for any critical functionality.
implementation(libs.db2.dialect)
gradlew.bat:73
- [nitpick] Ensure that clearing CLASSPATH is intentional and that the new -jar flag usage properly provides the necessary jar, as this change alters the wrapper's classpath configuration.
set CLASSPATH=
gradle/build-logic/src/main/kotlin/zip.kt:3
- [nitpick] Adding non-null constraints to the generic parameters improves type safety; please verify that this change meets the intended nullability requirements of the function.
internal fun <L : Any, C : Any, R : Any, V: Any> zip(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #879