Skip to content

feat!: complete custom resource migration#528

Open
damacus wants to merge 6 commits into
mainfrom
codex/complete-custom-resource-migration
Open

feat!: complete custom resource migration#528
damacus wants to merge 6 commits into
mainfrom
codex/complete-custom-resource-migration

Conversation

@damacus

@damacus damacus commented Mar 20, 2026

Copy link
Copy Markdown
Member

Summary

  • complete the AWS cookbook custom resource migration and remove the remaining legacy provider and top-level recipe entrypoints
  • align Kitchen, CI, docs, and metadata around a resource-only cookbook with a stubbed local default suite and live AWS acceptance workflow
  • add shared AWS resource properties, modernize EBS volume state handling, and expand ChefSpec/InSpec coverage across the public resource surface

Testing

  • cookstyle
  • chef exec rspec --format documentation
  • KITCHEN_LOCAL_YAML=kitchen.dokken.yml kitchen test default-ubuntu-2404 --destroy=always (blocked locally: Docker daemon unavailable at /var/run/docker.sock)

Finish the AWS cookbook custom resource migration by folding legacy provider logic into resources, removing top-level recipes, adding shared AWS properties, modernizing EBS volume state handling, and documenting the resource-only model.

Align Kitchen and CI on ubuntu-24.04 with a stubbed local default suite plus secret-backed live acceptance workflows, and add ChefSpec/InSpec coverage plus per-resource documentation for the public resource surface.
@damacus damacus requested a review from a team as a code owner March 20, 2026 13:11
damacus added 5 commits March 20, 2026 13:22
Preserve service-specific AWS stub payloads when running in local stub mode so the default DynamoDB suite exercises the intended create path.

Explicitly set the Kitchen suite verifiers to InSpec so local and live suites do not fall back to the legacy busser verifier during verify.
Replace the nonexistent chef/chef-workstation-action reference with the working Chef installer action used in current Sous-Chefs workflows, and set CHEF_LICENSE for the CI and live Kitchen commands.
Signed-off-by: Dan Webb <dan.webb@damacus.io>
@damacus

damacus commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

@thug-gamer would you mind taking this for a spin?

uses: actions/checkout@v5
- name: Install Chef
uses: actionshub/chef-install@main
uses: sous-chefs/.github/.github/actions/install-workstation@main

@thug-gamer thug-gamer Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to use an unpinned version? Alternatively you could pin the version and let renovate do dependency updates

Comment thread resources/dynamodb_table.rb
Comment on lines 91 to 92
# cfn_params_chagned - see if parameters have updated
def cfn_params_chagned?

@thug-gamer thug-gamer Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this typo and also update any references.
cfn_params_chagned -> cfn_params_changed

Comment thread kitchen.global.yml
- name: rockylinux-8
- name: rockylinux-9
- name: ubuntu-20.04
- name: ubuntu-22.04

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason you are dropping most platforms?

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
needs: lint-unit
steps:
- uses: actions/checkout@v4
- uses: sous-chefs/.github/.github/actions/install-workstation@main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Comment thread .github/workflows/live-acceptance.yml
Comment thread .github/workflows/live-acceptance.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants