Restrict humble packages to humble builds (#41).#42
Merged
Conversation
Contributor
Author
|
I've checked that this works by creating a branch in demos, making any clones of the CI building correctly in demos repo: 
Demo running correctly: 
|
Contributor
Author
|
@space-ros/maintainers, can I get an approval of this PR, please? |
ivanperez-keera
force-pushed
the
develop-fix-humble-jazzy
branch
from
July 6, 2026 17:42
3d213f9 to
e65eb7c
Compare
A recent update caused some packages to break due to them not being able to build the simulation repo when being installed on jazzy. This is affecting the demos repo, where now some demos no longer build. To keep this working until we can update all demos for jazzy, we want to protect the parts of the CMakeLists.txt that are specific to a ROS distro, so that they are ignored in other cases. This commit encloses the portions of the `CMakeLists.txt` that were affected by that update into conditions based on the ROS distribution for which the package is being compiled. It also adds conditions to the dependencies and exports included in the `package.xml` file so that they are only introduced when building on for the right ROS distribution.
ivanperez-keera
force-pushed
the
develop-fix-humble-jazzy
branch
from
July 6, 2026 17:43
e65eb7c to
edf1447
Compare
github-project-automation
Bot
moved this from In Review
to Done
in Space ROS Project Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent update caused some packages to break due to them not being able to build the simulation repo when being installed on jazzy. This is affecting the demos repo, where now some demos no longer build. To keep this working until we can update all demos for jazzy, we want to protect the parts of the CMakeLists.txt that are specific to a ROS distro, so that they are ignored in other cases.
This PR makes the parts of the
CMakeLists.txtandpackage.xmlthat are only forhumbleconditional, so that they are only built on that ROS distribution.