Repository navigation
Support encoding markers: skip python/ruby encoding if present in first two lines - #14
Merged
Merged
Conversation
becker33
force-pushed
the
bugfix/allow-extra-line-for-utf-encoding
branch
from
September 4, 2026 15:08
934fcc0 to
d38c148
Compare
Signed-off-by: Gregory Becker <becker33@llnl.gov>
becker33
force-pushed
the
bugfix/allow-extra-line-for-utf-encoding
branch
from
September 4, 2026 15:09
d38c148 to
c010fc5
Compare
Signed-off-by: Gregory Becker <becker33@llnl.gov>
tgamblin
requested changes
Sep 4, 2026
Signed-off-by: Gregory Becker <becker33@llnl.gov>
Signed-off-by: Gregory Becker <becker33@llnl.gov>
tgamblin
approved these changes
Sep 4, 2026
becker33
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python and Ruby can take code written in alternate encodings, but the encoding description must be written in a comment in the first two lines of the file.
To support this, sbang needs to look past the encoding to the third line of the file to find the interpreter if an encoding is being used.
This PR implements: