Repository navigation
Fix SmartQuotes cache reuse across builders - #14719
Open
Walentalien wants to merge 10 commits into
Open
Walentalien wants to merge 10 commits into
Walentalien wants to merge 10 commits into
Conversation
Walentalien
changed the title
SmartQuotes cache resuing across builds
Walentalien
changed the title
SmartQuotes cache resuing across buildsSmartQuotes cache reuse across builders
Walentalien
marked this pull request as ready for review
October 3, 2026 11:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I was working on fixing spellcheck for this project here when i ran into this.
Contractions with curly apostrophes in source were reported as errors.
I first fixed the source text (replaced with regular apostrophes that later are replaced through sphinx) but the build still reported same errors.
That because Sphinx was reusing cached docstrees from previous builder.
The workaround described in Sphinx docs is to build with -E option: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-smartquotes-excludes
This pr moves that responsibility for invalidating cache when builder-dependent Smart Quote state changes to Sphinx.
Builders with same state can continue reusing the cache.
References
Fixes #4371
Refs #8974
SystemsApproach/7E#58
AI Disclosure
gpt-sol-6.1 was used to implement/revise code.
chatGPT was used for investigation/reasoning/planning.
gemini-flash-3.8-flash was used to help with debugging.
All changes except
doc/usage/configuration.rstwere generated using aforementioned tools.CI note
The CI failures are unrelated to this PR and are being addressed in other PRs