Skip to content

feat(hash-persister): add --fallback-trigger-pattern flag - #23

Merged
honnix merged 1 commit into
mainfrom
honnix/fallback-trigger-pattern
Sep 29, 2026
Merged

honnix merged 1 commit into
mainfrom
honnix/fallback-trigger-pattern

Conversation

@honnix

@honnix honnix commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

A repeatable flag that forces a full rehash when any changed file matches the pattern (Go path.Match syntax).

--fallback-trigger-pattern 'config/tool-versions.yaml'
--fallback-trigger-pattern 'config/*.yaml'

Use case: CI-specific files that change the binaries or tools CI runs but are not visible to Bazel's build graph. Without this, changing such a file doesn't trigger a rehash, and the GCS cache may serve stale artifacts computed by the old binary.

Fallback code: unsafe_file_change (same as .bzl, lockfiles, etc.).

🤖 Generated with Claude Code

@honnix
honnix force-pushed the honnix/fallback-trigger-pattern branch from 79b5f3e to 1111256 Compare September 29, 2026 16:38
A repeatable flag that forces a full rehash when any changed file
matches the pattern (Go path.Match syntax). This lets callers specify
additional file paths that should trigger a fallback without modifying
isFallbackTrigger in the source.

Use case: CI-specific files like tools/savvy/etna.yaml that change the
binaries CI runs but are not visible to Bazel's build graph.

The fallback code is "fallback_trigger_pattern".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@honnix
honnix force-pushed the honnix/fallback-trigger-pattern branch from 1111256 to fc7d2be Compare September 29, 2026 16:40
@honnix
honnix marked this pull request as ready for review September 29, 2026 16:43
@honnix
honnix merged commit c18b04b into main Sep 29, 2026
2 checks passed
@mattnworb
mattnworb deleted the honnix/fallback-trigger-pattern branch October 1, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants