Conversation
- Add --help/-h early exit before venv setup - Use python -m pip instead of bin/pip (absent on some Debian/Ubuntu venvs) - Recreate venv if pip is not importable - Preflight check for python3-venv with clear install instructions - Detect available Python 3 binary rather than assuming python3 is valid - Use python -m pip install --prefer-binary to avoid slow source builds - Fix suite filter passing literal quotes to robot (-s '*'.tests.api.suite) by using a bash array SUITE_FILTER=(-s "*.tests.api.suite") - Add set -o pipefail so pipes propagate real exit codes - On UI: detect playwright OS-unsupported error, patch platform detection in coreBundle.js to use ubuntu24.04 builds for ubuntu26.x hosts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Defaults to headless. Pass --headed to open browser windows during UI test execution. Works with pabot (each worker opens its own window). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When pabot spawns worker processes, each one starts its own Node.js rfbrowser server that has no access to the parent DISPLAY. The documented fix (Browser/browser.py) is to start one shared server in the main process (which has DISPLAY) and point all workers to it via ROBOT_FRAMEWORK_BROWSER_NODE_PORT before pabot runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pabot worker subprocesses have no DISPLAY access so headed browsers never appear. In headed mode, skip pabot entirely and run all smoke tests sequentially with a single robot process. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…back Without this, playwright installs to ~/.cache/ms-playwright/ instead of the rfbrowser wrapper's .local-browsers directory, causing a missing executable error at test runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--help/-hnow exits immediately before any venv setuppython -m pipreplacesbin/pip(the binary is absent on some Debian/Ubuntu venvs)import pipfails; preflight check forpython3-venvwith clear install instructionspython3binary instead of assuming it exists--prefer-binaryon pip install avoids slow source compilation (grpcio, etc.)-s '*'.tests.api.suitewas passing literal apostrophes to robot; replaced with bash arraySUITE_FILTER=(-s "*.tests.api.suite")set -o pipefail: pipes now propagate the real exit code instead of always succeedingcoreBundle.jsto map ubuntu26.x hosts to ubuntu24.04 builds, then downloads the browser directlyTest plan
./bin/run-robot-suite-tests.sh --helpprints usage and exits 0./bin/run-robot-suite-tests.sh apiruns without suite filter errors./bin/run-robot-suite-tests.sh uiinstalls Chromium on Ubuntu 26.04 via the fallback patch🤖 Generated with Claude Code