Repository navigation
Correct the transmon Josephson-to-charging energy ratio - #94
Merged
Merged
Conversation
Contributor
Author
|
I cherry-picked the four independent SQDMetal fixes (#91-94) onto their shared upstream base and they apply cleanly together. Parser, LC, optimizer, transmon and the existing component geometry tests: 14 passed, 21 subtests passed. The optimizer/JSON run and a 61-state charge-basis Hamiltonian check also pass. With #94's corrected energy physics the floating original-target cost becomes 131.30895980700444 and still matches the independently calculated residual. CPU only, existing warnings not suppressed, no full suite or external EM solver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TransmonBase.EJonECreturnsh*f01/EC, notEJ/EC. Both Xmon and floating-transmon design objectives and reports use this method for theEj/Ecconstraint, so the wrong quantity is fitted and reported.For an effective capacitance of 60 fF and a 6.133905952808723 GHz transition, the leading-order transmon relation gives EJ/EC = 50. The original method instead reports 19.00000009487094.
Change
Invert
h*f01 = sqrt(8*EJ*EC) - EC, givingEJ/EC = (h*f01/EC + 1)**2/8, consistent with the existing_EJ_from_QubitFreqHertzhelper andEC = e**2/(2*Ceff)convention. No caller, signature or physical-constant changes.Document that this is a leading-order transmon approximation, not an exact charge-basis Hamiltonian solution; cite Koch et al. (2007), Eq. 11.
Verification
python -m pytest -q UnitTests/test_transmon_energy_ratio.py UnitTests/testBasicQiskitMetal.py: 3 passed, 9 subtests passed. Eight existing dependency/source deprecation warnings remain.H/EC = 4*n**2 - (EJ/EC)*cos(phi)at zero offset charge. Inverting its exact first transition gives 19.7029437359, 49.7100167695 and 99.7234611496 for ratios 20, 50 and 100: the expected finite-approximation differences, not exact-equality claims.Review and assistance
I supervised and checked the AI-assisted work as it progressed. AI assistance was used for investigation, implementation and verification. No maintainer review or approval is claimed. Verification was CPU-only; no GPU validation is claimed.