Repository navigation
Return port linewidths in Hz and support single-port eigenmodes - #97
Open
davrens101 wants to merge 1 commit into
Open
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Contributor
Author
|
I cherry-picked all seven SQDMetal fixes (#91-97) onto their shared upstream base and they apply cleanly together. The existing focused tests give 14 passed, 21 subtests passed (19 source/dependency/SciPy warnings, not suppressed). I also ran the 15 ordered three-mode EPR selections, 18 single-qubit capacitance configurations, three two-qubit input forms, single- and multi-port linewidths, and absent optional files directly, and they all work. No new permanent tests for #95-97, and I did not run the full suite or an external EM solver. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retrieve_mode_port_EPR_from_filedocuments linewidths in Hz, but returns Palace's GHz values without conversion. It also discards every valid single-port result as NaN by requiring at least two linewidth columns.Accept one or more linewidth columns and convert the existing absolute-value sum from GHz to Hz. Update the field-plot consumer to convert Hz to MHz; its displayed physical linewidth is unchanged for multi-port data. Missing/unavailable port data retain the existing NaN behavior. Public signatures and return keys are unchanged.
Primary source: Palace CSV writer creates
port-Q.csvfor any nonempty set of resistive ports and labels its linewidth columns with(GHz).Direct before/after verification, without mocks or new permanent tests:
Review and assistance
I supervised and checked the AI-assisted work as it progressed. AI assistance was used for investigation, implementation and verification. No maintainer review or approval is claimed. Verification was CPU-only; no GPU validation is claimed.