Add accessors for oneof's generated data classes#3594
Open
oldergod wants to merge 1 commit into
Open
Conversation
oldergod
force-pushed
the
bquenaudon.2026-05-11.readings
branch
from
95108e0 to
1c7fe5a
Compare
oldergod
force-pushed
the
bquenaudon.2026-05-11.readings
branch
from
1c7fe5a to
620e7cf
Compare
scmorse
reviewed
May 18, 2026
| accessorNameAllocator.newName(field.name, field) | ||
| } | ||
| val subclassName = sealedClassName.nestedClass(subclassNameAllocator[field]) | ||
| accessors += PropertySpec.builder(fieldName, field.type!!.typeName.copy(nullable = true)) |
There was a problem hiding this comment.
Do we need the if (field.isDeprecated) { and for (annotation in optionAnnotations(field.options)) { bits from sealedOneOfClass below, in order to propagate metadata / annotations on the extension fields too?
| private fun MessageType.flatOneOfs(): List<OneOf> = when (oneofMode) { | ||
| OneofMode.FLAT -> oneOfs.filter { it.fields.size < boxOneOfsMinSize } | ||
| else -> emptyList() | ||
| else -> listOf() |
There was a problem hiding this comment.
No problem, I'm just curious to understand why switching from emptyList() to listOf(), is that important?
| return when (type) { | ||
| is MessageType -> type.sealedOneOfAccessors() | ||
| is EnclosingType -> type.nestedTypes.flatMap(::generateSealedOneOfAccessors) | ||
| else -> listOf() |
There was a problem hiding this comment.
Nit, would prefer to see this last case listed out for exhaustivity and future-proofing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the extension on the sealed class, not the outer class, to make it clear it's going through a oneof