Cache thumbnails and support Dark Mode icons#267
Open
hutber wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two related UI improvements:
elementary-darkicon set, based on modified Elementary icons, for better visibility with dark themes.Details
The thumbnail cache stores scaled image pixbufs under the user gmusicbrowser home directory in a
thumbnailsfolder. Cache filenamesare generated from the source path, requested size, file size, and modification time, so cached thumbnails are invalidated when the
source image changes.
Animated images are excluded from the disk cache, matching the existing in-memory cache behavior.
Testing
Not formally tested. Changes are limited to image/icon assets and thumbnail loading/cache behavior.